fix: omitted `$ref` parameters #15

markandrus · 2024-12-14T19:18:16Z

I noticed there are some cases where parameters using $ref were omitted. This happens due to deleting the in property from the parameter, which then means, if the parameter is shared, it not longer has an in property, and is excluded from subsequent codegen steps. To fix that, I copy param in writeParameter.

Before this fix

const schema = {
  '/foo1': {
    GET: {
      args: T.Optional(
        T.Object({
          query: T.Optional(
            T.Object({
              bar: T.Optional(T.String({ 'x-in': 'query' }))
            })
          )
        })
      ),
      data: T.Any({ 'x-status-code': '201' }),
      error: T.Union([T.Any({ 'x-status-code': 'default' })])
    }
  },
  '/foo2': {
    GET: {
      args: T.Void(),
      data: T.Any({ 'x-status-code': '201' }),
      error: T.Union([T.Any({ 'x-status-code': 'default' })])
    }
  }
}

After this fix

const schema = {
  '/foo1': {
    GET: {
      args: T.Optional(
        T.Object({
          query: T.Optional(
            T.Object({
              bar: T.Optional(T.String({ 'x-in': 'query' }))
            })
          )
        })
      ),
      data: T.Any({ 'x-status-code': '201' }),
      error: T.Union([T.Any({ 'x-status-code': 'default' })])
    }
  },
  '/foo2': {
    GET: {
      args: T.Optional(
        T.Object({
          query: T.Optional(
            T.Object({
              bar: T.Optional(T.String({ 'x-in': 'query' }))
            })
          )
        })
      ),
      data: T.Any({ 'x-status-code': '201' }),
      error: T.Union([T.Any({ 'x-status-code': 'default' })])
    }
  }
}

fix: omitted $ref parameters

f1ba5d6

markandrus force-pushed the fix-omitted-ref-parameters branch from c4fa9e1 to f1ba5d6 Compare December 14, 2024 19:21

tinchoz49 merged commit 7fddb3e into geut:main Dec 16, 2024
1 check passed

markandrus deleted the fix-omitted-ref-parameters branch December 17, 2024 16:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: omitted `$ref` parameters #15

fix: omitted `$ref` parameters #15

markandrus commented Dec 14, 2024 •

edited

Loading

fix: omitted $ref parameters #15

fix: omitted $ref parameters #15

Conversation

markandrus commented Dec 14, 2024 • edited Loading

fix: omitted `$ref` parameters #15

fix: omitted `$ref` parameters #15

markandrus commented Dec 14, 2024 •

edited

Loading